Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cbindgen: ensure header is built with target #604

Merged
merged 3 commits into from
Jan 12, 2025

Conversation

jschwe
Copy link
Collaborator

@jschwe jschwe commented Jan 11, 2025

Ensure that the header is built together with the target it belongs to

@jschwe jschwe force-pushed the jschwender/cbindgen_install branch 2 times, most recently from a246600 to e856cea Compare January 12, 2025 10:22
If headers are generated with cbindgen, they should
probably always be available if the rust crate is also
available, so it makes sense to add a dependency.
The changed line was supposed to already do exactly that,
however interface targets are not actually built,
so we need to directly depend on the cargo-build_
custom command that generates the Rust library.
We already do this in other places, it was just
overlooked here.
@jschwe jschwe force-pushed the jschwender/cbindgen_install branch from e856cea to f0e38b0 Compare January 12, 2025 10:27
@jschwe jschwe force-pushed the jschwender/cbindgen_install branch from c97309e to 79efcbb Compare January 12, 2025 11:00
@jschwe jschwe merged commit f783ee8 into corrosion-rs:master Jan 12, 2025
40 checks passed
@jschwe jschwe deleted the jschwender/cbindgen_install branch January 12, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant